class: middle, center  --- class: middle, center ## hi my name is @ag_dubs hi  --- class: middle, center  --- class: middle, center ## from # OPEN ## to # MERGE --- class: middle, left - ## are you legally situated to contribute to this project? - ## is your contribution able to be merged with master? - ## does your contribution break functionality or style? - ## is your contribution something the project wants? --- class: middle, left #### Cast of Characters - ## bots - ## CLA - ## CI - ## maintainers/contributors --- class: middle, center #### are you legally situated to contribute to this project? # CLAs: Contributor License Agreement --- class: middle, center  --- class: middle, center #### is your contribution able to be merged with master?  --- class: middle, center #### does your contribution break functionality or style?  --- class: middle, center # Continuous Integration  --- class: middle, center #.travis.yml  --- class: middle, left - ## jshint - ## jscs - ## unit tests --- class: middle, center #### is your contribution something the project wants # WIP: Work in Progress --- class: middle, center  --- class: middle, center  --- class: middle, center # anyone can comment  --- class: middle, center # maintainers  --- class: middle, center # code review  --- class: middle, center  --- class: middle, center # this can take a long time --- class: middle, left #### if you added functionality... - ## is it documented? - ## is it tested? --- class: middle, center # sometimes, your PR gets closed  --- class: middle, center # and that is totally OK  --- class: middle, center # ZOMG IT'S TIME TO MERGE --- class: middle, center # you want me to what?  --- class: middle, center # commit histories matter --- class: middle, center  --- class: middle, center