+ - 0:00:00
Notes for current slide
Notes for next slide

PR

1 / 29

hi my name is @ag_dubs hi

me

2 / 29

sinatra code

3 / 29

from

OPEN

to

MERGE

4 / 29

  • are you legally situated to contribute to this project?

  • is your contribution able to be merged with master?

  • does your contribution break functionality or style?

  • is your contribution something the project wants?

5 / 29

Cast of Characters

  • bots

  • CLA

  • CI

  • maintainers/contributors

6 / 29

are you legally situated to contribute to this project?

CLAs: Contributor License Agreement

7 / 29

CLA bot

8 / 29

is your contribution able to be merged with master?

rebase

9 / 29

does your contribution break functionality or style?

break

10 / 29

Continuous Integration

travis

11 / 29

.travis.yml

travis yaml

12 / 29

  • jshint

  • jscs

  • unit tests

13 / 29

is your contribution something the project wants

WIP: Work in Progress

14 / 29

wip PR

15 / 29

issue first

16 / 29

anyone can comment

troll

17 / 29

maintainers

shepard

18 / 29

code review

review

19 / 29

inline

20 / 29

this can take a long time

21 / 29

if you added functionality...

  • is it documented?

  • is it tested?

22 / 29

sometimes, your PR gets closed

sad charlie brown

23 / 29

and that is totally OK

more than one night

24 / 29

ZOMG IT'S TIME TO MERGE

25 / 29

you want me to what?

squash

26 / 29

commit histories matter

27 / 29

how to squash

28 / 29

merge merge merge merge merge merge merge merge merge merge merge merge merge merge merge merge merge merge merge merge merge merge merge merge merge merge merge merge merge merge

29 / 29

hi my name is @ag_dubs hi

me

2 / 29
Paused

Help

Keyboard shortcuts

↑, ←, Pg Up, k Go to previous slide
↓, →, Pg Dn, Space, j Go to next slide
Home Go to first slide
End Go to last slide
b / m / f Toggle blackout / mirrored / fullscreen mode
c Clone slideshow
p Toggle presenter mode
t Restart the presentation timer
?, h Toggle this help
Esc Back to slideshow